Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-1835: individual operator conditions must be set atomically #2039

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

API-1835: individual operator conditions must be set atomically #2039

wants to merge 2 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 23, 2024

/hold

our current testing doesn't allow this to be tested in integration testing. I'll test manually I guess.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@deads2k deads2k changed the title individual operator conditions must be set atomically API-1835: individual operator conditions must be set atomically Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

/hold

our current testing doesn't allow this to be tested in integration testing. I'll test manually I guess.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
bertinatto
bertinatto reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the intention here is to avoid the controller to:

  1. Loop through all existing conditions,
  2. Identify the specific condition to modify,
  3. And update only a single field, such as the status.

Instead, the expectation is that the controller should update the entire condition struct in one go. This approach applies to individual conditions and not the entire list of conditions, as the field is already defined as a map listType.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Sep 25, 2024

/hold cancel

worked locally

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3c700b6 and 2 for PR HEAD c1f5237 in total

@bertinatto
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3c700b6 and 2 for PR HEAD c1f5237 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 46b9486 and 1 for PR HEAD c1f5237 in total

@bertinatto
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 46b9486 and 2 for PR HEAD c1f5237 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 46b9486 and 2 for PR HEAD c1f5237 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 46b9486 and 2 for PR HEAD c1f5237 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f89ab92 and 2 for PR HEAD c1f5237 in total

@deads2k
Copy link
Contributor Author

deads2k commented Sep 27, 2024

/hold

something else should have failed

deads@fedora:~/workspaces/cluster-debug-tools/src/github.com/openshift/cluster-debug-tools$ ./kubectl-dev_tool audit -f '/home/deads/Downloads/audit-logs(14)/registry-build03-ci-openshift-org-ci-op-5n926cq2-stable-sha256-1bcf20915cd7b01643a5555630e06be72e4fef84cd34d1bdd10242c9fcf6cfdf/audit_logs/kube-apiserver' --resource=authentications.operator.openshift.io -otop --by=verb
had 4074 line read failures
count: 21152, first: 2024-09-26T10:46:01-04:00, last: 2024-09-26T11:36:58-04:00, duration: 50m56.399871s

Top 10 "GET" (of 9994 total hits):
   9956x [  5.314652ms] [200-9955] /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-authentication-operator:authentication-operator]
     33x [  5.403242ms] [200-32]   /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-cluster-version:default]
      3x [  3.375666ms] [200-2]    /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:kube-system:generic-garbage-collector]
      1x [    25.295ms] []         /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-must-gather-g4mxv:default]
      1x [    38.892ms] []         /apis/operator.openshift.io/v1/authentications/cluster [system:serviceaccount:openshift-insights:operator]

Top 10 "LIST" (of 11 total hits):
      6x [  7.997833ms] [200-5] /apis/operator.openshift.io/v1/authentications?resourceVersion=17788 [system:kube-controller-manager]
      5x [    7.3292ms] [200-4] /apis/operator.openshift.io/v1/authentications?resourceVersion=17788 [system:serviceaccount:openshift-authentication-operator:authentication-operator]

Top 10 "PATCH" (of 6328 total hits):
   6328x [ 14.389349ms] [200-6327] /apis/operator.openshift.io/v1/authentications/cluster/status?fieldManager=APIServiceController_openshift-apiserver-updateOperatorStatus&force=true [system:serviceaccount:openshift-authentication-operator:authentication-operator]

Top 10 "UPDATE" (of 4798 total hits):
   2787x [  8.197066ms] [200-15,409-2771] /apis/operator.openshift.io/v1/authentications/cluster/status [system:serviceaccount:openshift-authentication-operator:authentication-operator]
   2011x [  8.434701ms] [200-1,409-2009]  /apis/operator.openshift.io/v1/authentications/cluster        [system:serviceaccount:openshift-authentication-operator:authentication-operator]

Top 10 "WATCH" (of 21 total hits):
     12x [4m7.47246325s] [200-11] /apis/operator.openshift.io/v1/authentications?allowWatchBookmarks=true&resourceVersion=17788&timeout=5m12s&timeoutSeconds=312&watch=true [system:kube-controller-manager]
      9x [3m37.424657s] [200-8]   /apis/operator.openshift.io/v1/authentications?allowWatchBookmarks=true&resourceVersion=17788&timeoutSeconds=377&watch=true               [system:serviceaccount:openshift-authentication-operator:authentication-operator]

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Sep 27, 2024

oh! the install failed so the monitortest to catch excessive applies didn't happen

@deads2k
Copy link
Contributor Author

deads2k commented Oct 2, 2024

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/minor-e2e-upgrade-minor c1f5237 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-serial-techpreview c1f5237 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn c1f5237 link true /test e2e-aws-ovn
ci/prow/e2e-azure c1f5237 link false /test e2e-azure
ci/prow/e2e-upgrade c1f5237 link true /test e2e-upgrade
ci/prow/e2e-aws-serial c1f5237 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview c1f5237 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-gcp c1f5237 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Oct 3, 2024

such a small change, such a massive failure. I wonder what's next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deads2k @openshift-ci-robot @bertinatto